perf: blazingly fast #7799
Merged
perf: blazingly fast #7799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Sep 24, 2024
gomesalexandre
changed the title
gomesalexandre
commented
Sep 24, 2024
0xApotheosis
approved these changes
Sep 25, 2024
gomesalexandre
force-pushed
the
feat_split_reducers_persist
branch
from
41895f2
to
de470e2
Compare
NeOMakinG
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
- Regeneration assets is properly creating a new line inside
clearAssetsMigrations - Assets migration seems to be working as expected
- Rehydration also seems to work as expected
I had a problem with the history of BTC but as seen in pm, it doesn't look linked with this PR
We have to take a lot of care with this PR because it will be pretty hard to revert if we push it to production, people would end in a borked state (I did try to come back to develop and I had to flush my cache to make it work)
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt 1 at redux perf. improvements
Issue (if applicable)
Risk
High - touches state. Getting this wrong could brick state, and we'd have to revert this and do a nuke of the whole state.
Testing
Engineering
NOTE: Ensure you check for slice state after rehydration (i.e
{rehydrated: true}for the slice/s you're migrating) to ensure redux-persist rehydrated with your migration:Operations
Screenshots (if applicable)
https://jam.dev/c/6fee8b7a-97d8-48b0-b420-b04f3ef008b4